Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update code generation section to add CXF #157

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update code generation section to add CXF #157

wants to merge 1 commit into from

Conversation

anandkp92
Copy link
Member

No description provided.

mwetter
mwetter requested changes Dec 5, 2024
View reviewed changes
Copy link
Member

@mwetter mwetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see inline comments.

specification/source/codeGeneration.rst
CDL to their native language. To aid in this process, an intermediate
Control eXchange Format (CXF) can be used. CXF is a JSON-LD representation
of a CDL sequence, serialized in JSON. `Modelica-json <https://github.com/lbl-srg/modelica-json>`_
is a reference implementation of such a CDL to CXF translator.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The translator is not a "reference implementation" as the translator is not part of the standard. Just write it is a translator.

specification/source/codeGeneration.rst
Control eXchange Format (CXF) can be used. CXF is a JSON-LD representation
of a CDL sequence, serialized in JSON. `Modelica-json <https://github.com/lbl-srg/modelica-json>`_
is a reference implementation of such a CDL to CXF translator.
This translator first parses CDL-compliant control sequences to a abstract
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Write "an abstract"

@anandkp92
Copy link
Member Author

  • describe what BAS is (maybe EMIS falls under it?)
  • update figure to add CDL -> Xeto/ CDL -> WebCTRL
  • change JSOn to CXF
  • Karl -> CDL -> PLC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwetter mwetter mwetter requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anandkp92 @mwetter