Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Medieval and Fortress fixes and Shire and Fortress rebalancing in 1.20.1 #10364

Merged
merged 6 commits into from
Oct 28, 2024
Merged

Medieval and Fortress fixes and Shire and Fortress rebalancing in 1.20.1 #10364

merged 6 commits into from
Oct 28, 2024

Conversation

MotionlessTrain
Copy link
Contributor

Closes #
Closes #

Changes proposed in this pull request

  • Rebalancing
    • Remove level 5 blocks from the level 4 Fortress enchanter's tower
    • Anti-cheese the Shire level 5 alternate builder's hut by addinng level 5 blocks there
    • Reduce amount of tags in the Fortress sugarcane plantatino field
  • Fix
    • Fix the DO blocks in the medieval birch town hall
  • Fixes using two scripts
    • Mass-fix shingle slabs in Medieval styles. They were rendering a two-way shingle slab at the end, giving a graphical glitch where you could look through them.
    • Mass fix decoration controllers for legacy decorations. The ones that were showing e.g. road1, road2, road3 and road4 as seperate decorations in the build tool should now be nicely stacked up as levels under road1. This affects mostly Fortress and Medieval, but possible some Desert Oasis schematics too

Testing

  • Yes I tested this before submitting it.
    • That is, I verified that the levellable decorations are now shown properly
  • I also did a multiplayer test.

Review please

@MotionlessTrain MotionlessTrain mentioned this pull request Oct 26, 2024
Merged
2 tasks
@Raycoms Raycoms merged commit 0790bb6 into ldtteam:version/main Oct 28, 2024
5 checks passed
@MotionlessTrain MotionlessTrain deleted the fix/medieval-20 branch October 29, 2024 22:21
@MotionlessTrain MotionlessTrain mentioned this pull request Nov 6, 2024
Merged
2 tasks
Raycoms pushed a commit that referenced this pull request Nov 8, 2024
@MotionlessTrain
Fortress, medieval and Ancient athens fixes and Jungle Treehouse twea…
ea7465a 
…ks (part 3) in 1.20.1 (#10415)

Followup to Medieval and Fortress fixes and Shire and Fortress rebalancing in 1.20.1 #10364.
In the fix of the decorations not being shown as levellable in the build tool, it turned out that the decoration controller broke,
as I forgot to set a pack in the fixed decorations. I thought including a path and schematicName would be enough to tell the decoration controller to not use the legacy code anymore, but it was looking at the pack NBT-component instead.
I've been thinking about removing the legacy code in TileEntityDecorationController as well,
as the decorations for which that was still needed should now all be migrated. But I wasn't sure whether that would be better in a separate PR
Edit: I didn't check whether it would be needed in Stylecolonies, as a few styles there (at least Frontier) stems from before 1.19
Move the medium_military harbour pier decoration in Ancient athens to the correct folder
Rebalance some placeholders on the Jungle Treehouse sifter's hut. Some areas were under-placeholdered, and others were over-placeholdered
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MotionlessTrain @Raycoms