-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update to stacks.js 4.0.0 (removes username checking) #2333
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/blockstack/stacks-wallet-web/ES6gaTMMoU8WKJrBpXMfYxS2vTzB |
dbf0f5f
to
e20a2ea
Compare
7d34d86
to
f7263cf
Compare
3b6d323
to
99c0673
Compare
@kantai @larrysalibra @hstove @kyranjamie I'd be curious whether any of you see any immediate dangers to removing BNS-related queries from authentication in general per this PR. @janniks is working on this approach as a way to resolve a variety of BNS-related issues that have cropped up, especially regarding expired, renewed and "legacy" Stacks 1.0 names. And this seems like a possibly efficient way to resolve them all at once. |
Where can we see the changes made to auth? I can't think of any immediate dangers. Auth does a lot so if we can decouple any BNS features of it, then great. I don't fully understand why auth needs to look up/match BNS names in the first place. |
I agree that name resolution should be decoupled from authentication. It's easy enough to expose functions to resolve names to addresses, I personally don't think it needs to be included in an authentication response. |
efd0912
to
54e2da7
Compare
66716ea
to
ced2efa
Compare
It's happening 🔥 can't wait to see this one merged so we can finally add Hiro wallet support to Sigle! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🥳
in 0f3a2b9 I had to skip a test (not sure why this fails), if somebody wants to look into it. may be related to switching to in 0f3a2b9 I also added handing back off to #userx, feel free to merge, or just use as a test-app for |
Yeah, I do like this! In general I'm a fan of supporting a more "virtual" auth flow. On ETH there are no auth checks, so you can "log in" as any address you want to an app. This has some nice benefits - like I can login to an app using my vault address while on my phone, which doesn't have that key. If an app wants to strictly verify ownership (which is a more edge use-case, like gating premium features) they can always use other APIs for that. |
Before we merge, can we rebase this PR into 1 (or a few) commits 🙏🏼 |
0f3a2b9
to
c4dd676
Compare
c4dd676
to
c5a3886
Compare
c5a3886
to
ff74b82
Compare
scope
4.0.0
node
test environment