Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SiPM Optimization #52

Merged
merged 8 commits into from
Feb 3, 2025

Bug fix threshold grid calculation

df4dc89
Select commit
Loading
Failed to load commit list.
Merged

SiPM Optimization #52

Bug fix threshold grid calculation
df4dc89
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Feb 3, 2025 in 1s

30.58% (-1.24%) compared to c3d2f24

View this Pull Request on Codecov

30.58% (-1.24%) compared to c3d2f24

Details

Codecov Report

Attention: Patch coverage is 0% with 59 lines in your changes missing coverage. Please review.

Project coverage is 30.58%. Comparing base (c3d2f24) to head (df4dc89).

Files with missing lines Patch % Lines
src/dsp_sipm_optimization.jl 0.00% 41 Missing ⚠️
src/dsp_puls.jl 0.00% 16 Missing ⚠️
src/dsp_sipm.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
- Coverage   31.81%   30.58%   -1.24%     
==========================================
  Files          24       24              
  Lines        1188     1236      +48     
==========================================
  Hits          378      378              
- Misses        810      858      +48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.