Implement the "dns-account-01" Challenge #430
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orangepizza
force-pushed
the
dns-account
branch
from
458035d
to
c246231
Compare
Closed
|
👋🏽 Hi @orangepizza and thanks for the contributing this feature! The intent with #425 is to implement the challenge as described in aaomidi/draft-ietf-acme-scoped-dns-challenges#25. Adding fastly@2afa9f4 will make the validation label match the updated RFC draft. const dnsacct01Prefix = "_acme-challenge"
…
challengeSubdomain := fmt.Sprintf("_%s.%s.%s", urlhash, dnsacct01Prefix, task.Identifier.Value) |
|
updated for new scoped challenge: but looks too late :( |
|
superseded by #435 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solve #425
implement https://datatracker.ietf.org/doc/draft-ietf-acme-dns-account-challenge/
as only thing different is from dns-01 is challenge subdomain craft, which needs what hostname user expects:
this PR handed this by sending relative accountURL path from WFE to VA.
need client impl but as hash craft itself is tested to make same result from RFC draft input, and using same craft function for accountURL craft that used with other url endpoints like new-reg