Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create dockerfile and add docker publish ci #32

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

LeoQuote
Copy link

No description provided.

* add docker release

* add dockerfile
FROM scratch
COPY --from=build-env /go/bin/unbound_exporter /usr/bin/unbound_exporter
ENTRYPOINT ["unbound_exporter"]
CMD ["-unbound.host", "tcp://localhost:8953"]
Copy link

@vincejv vincejv Sep 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be a lot better to store this arg as a docker environment variable rather than being a constant value

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair point but the better way to do that is to override this directly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants