Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualstudio solution #517

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Conversation

FredeJ
Copy link

@FredeJ FredeJ commented Oct 25, 2019

Migrate the solution file to Visual Studio 15.

The goal of this is to allow libtomcrypt to be made available through vcpkg (https://github.com/microsoft/vcpkg/)

@sjaeckel sjaeckel requested a review from karel-m October 25, 2019 14:05
@karel-m
Copy link
Member

karel-m commented Oct 25, 2019

👎 While you are able to import the old format (VS2008) into newer Visual Studio (e.g. VS2015) it is not possible the other way around. I am for keeping VS2008 compatibility.

@sjaeckel
Copy link
Member

@FredeJ is it an option to use the makefile.msvc for your purpose?

@karel-m
Copy link
Member

karel-m commented Oct 25, 2019

No, makefile.msvc is not what I want.

The other thing is that it is not sufficient to just save the original .vcproj as .vcxproj. Somebody has also update helper.pl so that the .vcxproj file is updated when a new source file is added, deleted or renamed.

@sjaeckel
Copy link
Member

No, makefile.msvc is not what I want.

I asked @FredeJ ;-)

The other thing is that it is not sufficient to just save the original .vcproj as .vcxproj. Somebody has also update helper.pl so that the .vcxproj file is updated when a new source file is added, deleted or renamed.

Right, I thought that was done, but apparently it wasn't.

@karel-m
Copy link
Member

karel-m commented Oct 25, 2019

I will support this PR only when it keeps support for both cases:

  • libtomcrypt_VS2008.sln + libtomcrypt_VS2008.vcproj
  • libtomcrypt_VS2015.sln + libtomcrypt_VS2015.vcxproj (not sure about having .vcxproj.filters in git)

But again, somebody has to fix helper.pl so that it is able to update .vcxproj.

@FredeJ
Copy link
Author

FredeJ commented Oct 28, 2019

@sjaeckel makefile.msvc seems to be able to get me basically 95% there. I was not aware of nmake at all but was just using msbuild, which failed with the older project and solution files.

Now all I'm missing is figuring out how to build both debug and release, and both libtomcrypt and libtommath should be buildable with vcpkg :)

@sjaeckel
Copy link
Member

@sjaeckel makefile.msvc seems to be able to get me basically 95% there

cool :)

Now all I'm missing is figuring out how to build both debug and release, and both libtomcrypt and libtommath should be buildable with vcpkg :)

uhm, pass in some CFLAGS and change the libname for the debug build? something like nmake -f makefile.msvc CFLAGS="-MTd" LIBMAIN_S="tomcrypt-debug.lib"

I don't run windows, so I can't tell if it's exactly like that, but that should give you a direction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants