Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-nest queries in NestedFrame.query should be prohibited or split #160

Closed
3 tasks done
gitosaurus opened this issue Oct 28, 2024 · 0 comments · Fixed by #165
Closed
3 tasks done

Cross-nest queries in NestedFrame.query should be prohibited or split #160

gitosaurus opened this issue Oct 28, 2024 · 0 comments · Fixed by #165
Assignees
Labels
bug Something isn't working

Comments

@gitosaurus
Copy link
Contributor

Bug report

Before submitting
Please check the following:

  • I have described the situation in which the bug arose, including what code was executed, information about my environment, and any applicable data others will need to reproduce the problem.
  • I have included available evidence of the unexpected behavior (including error messages, screenshots, and/or plots) as well as a description of what I expected instead.
  • If I have a solution in mind, I have provided an explanation and/or pseudocode and/or task list.

Processing queries across base and nested columns is not possible in NestedFrame.query today, so expressions of this kind are detected and prohibited. However, it does not presently prohibit queries that go across two different nests:

nf.query("n1.c < 0.5 and n2.d > 1e-7")

The above will "work", but only selects the nested rows in n1, simply because n1 is earlier in the string.

The solution is to treat such cross-nest queries exactly the same as queries that cross base and nested columns: error out today, and as split queries, in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant