Query expression preflighting now prohibits crossing nests.

[gitosaurus]

Doing so never worked, but now it is correctly detected.

Resolves #160 .

Change Description

• My PR includes a link to the issue that I am addressing

Solution Description

The expression-tree scanning that was done before is now expanded so that it not only notices the use of nests, but tracks the nest columns' identifiers.

Code Quality

• I have read the Contribution Guide
• My code follows the code style of this project
• My code builds (or compiles) cleanly without any errors or warnings
• My code contains relevant comments and necessary documentation

Project-Specific Pull Request Checklists

Bug Fix Checklist

• My fix includes a new test that breaks as a result of the bug (if possible)
• My change includes a breaking change
  • My change includes backwards compatibility and deprecation warnings (if possible)

[github-actions]

Before [d379665]	After [e53169f]	Ratio	Benchmark (Parameter)
30.4±6ms	46.5±8ms	~1.53	benchmarks.ReassignHalfOfNestedSeries.time_run
22.1±0.2ms	23.7±0.1ms	1.07	benchmarks.AssignSingleDfToNestedSeries.time_run
88.1M	88.5M	1.01	benchmarks.NestedFrameAddNested.peakmem_run
266M	266M	1.00	benchmarks.AssignSingleDfToNestedSeries.peakmem_run
93.2M	93.2M	1.00	benchmarks.NestedFrameQuery.peakmem_run
7.99±0.04ms	7.99±0.1ms	1.00	benchmarks.NestedFrameQuery.time_run
91.8M	91.8M	1.00	benchmarks.NestedFrameReduce.peakmem_run
1.61±0.01ms	1.62±0.01ms	1.00	benchmarks.NestedFrameReduce.time_run
285M	285M	1.00	benchmarks.ReassignHalfOfNestedSeries.peakmem_run
9.85±0.1ms	9.57±0.1ms	0.97	benchmarks.NestedFrameAddNested.time_run

Click here to view all benchmarks.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.49%. Comparing base (b8707a9) to head (a03b23b).
Report is 7 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #165   +/-   ##
=======================================
  Coverage   99.49%   99.49%           
=======================================
  Files          14       14           
  Lines         984      985    +1     
=======================================
+ Hits          979      980    +1     
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[wilsonbb]

Overall it looks pretty good, but I am a bit confused by a part of _actionable_splits. Can check again in the morning.

[hombit]

Could you please add a higher level test checking that an example from #160 fails?

[gitosaurus]

Could you please add a higher level test checking that an example from #160 fails?

Done!