Skip to content

Fix a failure for nest["field"] and empty chunks #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025
Merged

Conversation

hombit
Copy link
Collaborator

@hombit hombit commented Jun 18, 2025

This morning I was running a pipeline with LSDB and got an exception complaining about empty input for pa.chunked_array.

I don't really know how to reproduce it (empty dataframe/series didn't work), but this PR should fix it. I also changed a similar code in another place for consistency.

@hombit hombit requested a review from dougbrn June 18, 2025 14:31
Copy link

codecov bot commented Jun 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.73%. Comparing base (e18390e) to head (cc40fb2).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #292      +/-   ##
==========================================
+ Coverage   97.67%   97.73%   +0.05%     
==========================================
  Files          18       18              
  Lines        1632     1630       -2     
==========================================
- Hits         1594     1593       -1     
+ Misses         38       37       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

Before [e18390e] <v0.4.5> After [4b5b976] Ratio Benchmark (Parameter)
46.4±0.01ms 41.3±1ms ~0.89 benchmarks.ReassignHalfOfNestedSeries.time_run
28.1±0.5ms 29.0±0.6ms 1.03 benchmarks.AssignSingleDfToNestedSeries.time_run
1.43±0.02ms 1.44±0.03ms 1.01 benchmarks.NestedFrameReduce.time_run
246M 246M 1.00 benchmarks.AssignSingleDfToNestedSeries.peakmem_run
134M 134M 1.00 benchmarks.CountNestedBy.peakmem_run
70.4±1ms 70.6±1ms 1.00 benchmarks.CountNestedBy.time_run
101M 101M 1.00 benchmarks.NestedFrameAddNested.peakmem_run
104M 104M 1.00 benchmarks.NestedFrameQuery.peakmem_run
104M 104M 1.00 benchmarks.NestedFrameReduce.peakmem_run
267M 267M 1.00 benchmarks.ReassignHalfOfNestedSeries.peakmem_run

Click here to view all benchmarks.

@hombit hombit enabled auto-merge June 18, 2025 15:59
Copy link
Collaborator

@dougbrn dougbrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hombit hombit merged commit 94621d7 into main Jun 18, 2025
11 checks passed
@hombit hombit deleted the empty-chunks-accessor branch June 18, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants