initialize nestedframe #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hombit
reviewed
Apr 3, 2024
src/nested_pandas/__init__.py
Outdated
| @@ -1,4 +1,5 @@ | |||
| from .example_module import greetings, meaning | |||
| from .nestedframe import NestedFrame # noqa | |||
There was a problem hiding this comment.
Let's remove noqa and add to __all__?
| @@ -0,0 +1 @@ | |||
| from .core import * # noqa | |||
There was a problem hiding this comment.
Do we really need star-import here? It would add pd and other stuff we don't really need
| """returns a dictionary of columns for each base/nested dataframe""" | ||
| all_columns = {"base": self.columns} | ||
| for column in self.columns: | ||
| if hasattr(self[column], "nest"): |
There was a problem hiding this comment.
I would check column's dtype instead, it should be NestedDtype. No code suggestion here, because we need to import it first
from nested_pandas import NestedDtype
if isinstance(self[column].dtype, NestedDtype):| all_columns = {"base": self.columns} | ||
| for column in self.columns: | ||
| if hasattr(self[column], "nest"): | ||
| nest_cols = self[column].iloc[0].columns # TODO: Improve access to columns |
There was a problem hiding this comment.
Suggested change
| nest_cols = self[column].iloc[0].columns # TODO: Improve access to columns | |
| nest_cols = self[column].nest.fields() |
| """retrieves the base column names for all nested dataframes""" | ||
| nest_cols = [] | ||
| for column in self.columns: | ||
| if hasattr(self[column], "nest"): |
There was a problem hiding this comment.
Suggested change
| if hasattr(self[column], "nest"): | |
| if isinstance(self[column].dtype, NestedDtype): |
Comment on lines
51
to
53
| else: | ||
| return False | ||
| else: |
There was a problem hiding this comment.
It is a matter of taste, but I believe we don't need these else:s here
|
Thanks for the comments, I've addressed them all in the latest commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initializes the NestedFrame module. Adds a few properties and an initial add_nested function.