Rename Stretch, Style, Weight to have Font prefix
#211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm sort of mixed on this, but:
So it would be nice to have a single name for these. In this PR, I chose |
waywardmonkeys
force-pushed
the
rename-fontique-attributes
branch
from
f27a037 to
16e9600
Compare
nicoburns
approved these changes
Dec 9, 2024
|
linebender/xilem#778 shows why having a single name in Parley and Fontique will be good (and why that name should be |
dfrg
approved these changes
Dec 9, 2024
In a subsequent PR, I will suggest renaming |
This brings them into line with how they're used in `parley::style` as well as closer to how they're named in CSS where these properties are `font-stretch` (since renamed to `font-width`), `font-style`, and `font-weight`. This is a precursor to extracting this code into a separate crate for styling text.
waywardmonkeys
force-pushed
the
rename-fontique-attributes
branch
from
16e9600 to
2501041
Compare
waywardmonkeys
added a commit
to waywardmonkeys/parley
that referenced
this pull request
Dec 9, 2024
This exposes `from_fontconfig` functions on `FontStretch`, `FontStyle`, and `FontWeight` rather than only defining them locally within the fontconfig code. This is in preparation for a change similar to linebender#211 where these types and others get pulled into a shared vocabulary crate and this sort of constructor helper would be useful to others.
waywardmonkeys
added a commit
to waywardmonkeys/parley
that referenced
this pull request
Dec 9, 2024
This exposes `from_fontconfig` functions on `FontStretch`, `FontStyle`, and `FontWeight` rather than only defining them locally within the fontconfig code. This is in preparation for a change similar to linebender#211 where these types and others get pulled into a shared vocabulary crate and this sort of constructor helper would be useful to others.
waywardmonkeys
added a commit
to waywardmonkeys/parley
that referenced
this pull request
Dec 9, 2024
This can be used in the future as part of FFI work, but for now, the `Contiguous` trait is used to provide a `MAX_VALUE` used by `GenericFamilyMap`. This is a backport of part of linebender#211 where the separation between `GenericFamily` and `GenericFamilyMap` has grown to span crates.
waywardmonkeys
added a commit
to waywardmonkeys/parley
that referenced
this pull request
Dec 9, 2024
This can be used in the future as part of FFI work, but for now, the `Contiguous` trait is used to provide a `MAX_VALUE` used by `GenericFamilyMap`. This is a backport of part of linebender#211 where the separation between `GenericFamily` and `GenericFamilyMap` has grown to span crates. The testing here borrows from (copies) what is done for similar testing of `bytemuck` traits in the `color` crate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings them into line with how they're used in
parley::styleas well as closer to how they're named in CSS where these properties arefont-stretch(since renamed tofont-width),font-style, andfont-weight.This is a precursor to extracting this code into a separate crate for styling text.