Support floating point hue in hsl()
and hsla()
#31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Browsers support a color like
hsl(120.152, 100%, 75%)
but this library would incorrectly parse the hue and fallback to black.Changes parsing the hue as an integer to parsing as a number.
CSS Color Module Level 3 4.2.4 suggests that the hue should be a number (and not strictly an integer):
CSS Color Module Level 4 is more explicit that hue can be a number.
This PR also comments out the
parse_integer
andparse_list_integer
functions (and relevant tests) fromsrc/stream.rs
because leaving them in the code produced these warnings during build:Happy to uncomment or remove them completely if that's preferred.
Related to vercel/satori#602