checking newNode size to make sure its not 0 #520
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a check inside NetworkClient for newNodes.size equalling 0 so that 0 isn't passed into:
int offset = this.randOffset.nextInt(newNodes.size());
resulting in logs blowing up due to "java.lang.IllegalArgumentException: bound must be positive".
For tests I have set no bootstrap urls in the client so when i try and resolve addresses none are found and thus no newNodes are found thus setting the size equal to 0 and return null after its initial exception is thrown.
Committer Checklist (excluded from commit message)