Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checking newNode size to make sure its not 0 #520

Merged
merged 5 commits into from
Sep 3, 2024
Merged

checking newNode size to make sure its not 0 #520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bb224b3
checking newNode size to make sure its not 0
JobseRyan Aug 28, 2024
c2d281a
adding UT for no newNodes
JobseRyan Aug 28, 2024
c3d21a4
fixing ut
JobseRyan Aug 28, 2024
77b3211
fixing ut
JobseRyan Aug 28, 2024
431c0c0
adding exception import
JobseRyan Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions clients/src/main/java/org/apache/kafka/clients/NetworkClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -990,6 +990,10 @@ public Node leastLoadedNode(long now) {
newNodes.add(new Node(nodeId--, address.getHostString(), address.getPort()));
}

if (newNodes.size() == 0) {
return null;
JobseRyan marked this conversation as resolved.
Show resolved Hide resolved
}

int offset = this.randOffset.nextInt(newNodes.size());
Node node = newNodes.get(offset);
log.trace("Resolved bootstrap server again, randomly picked node {} as least loaded node from the resolved node set", node);
Expand Down
14 changes: 14 additions & 0 deletions clients/src/test/java/org/apache/kafka/clients/NetworkClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

import java.util.PriorityQueue;
import org.apache.kafka.common.Cluster;
import org.apache.kafka.common.config.ConfigException;
import org.apache.kafka.common.KafkaException;
import org.apache.kafka.common.Node;
import org.apache.kafka.common.errors.AuthenticationException;
Expand Down Expand Up @@ -631,6 +632,19 @@ public void testResolveBootstrapInLeastLoadedNode() {
assertNotEquals(node, clusterClient.leastLoadedNode(time.milliseconds()));
}

@Test
public void noLeastLoadedNode() {
NetworkClient nc = new NetworkClient(selector, clusterMetadataUpdater, "mock-cluster-md", Integer.MAX_VALUE,
0, 0, 64 * 1024, 64 * 1024,
defaultRequestTimeoutMs, connectionSetupTimeoutMsTest, connectionSetupTimeoutMaxMsTest, time, true, new ApiVersions(), new LogContext(),
LeastLoadedNodeAlgorithm.VANILLA, new ArrayList<>());
nc.ready(node, time.milliseconds());
assertFalse(client.isReady(node, time.milliseconds()));
assertThrows(ConfigException.class, () -> nc.leastLoadedNode(time.milliseconds()));

assertEquals(null, nc.leastLoadedNode(time.milliseconds()));
}

@Test
public void testLeastLoadedNode() {
client.ready(node, time.milliseconds());
Expand Down
Loading