[controller] Fix mismatch between hybrid version partition count and real-time partition count #1338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rtition count This fix addresses an issue where the real-time topic partition count did not align with the hybrid version partition count, causing errors during hybrid store operations. The issue occurred in the following scenario: 1. Create a store with 1 partition. 2. Perform a batch push, creating a batch version with 1 partition. 3. Update the store to 3 partitions and convert it to a hybrid store. 4. Start real-time writes using push type STREAM. 5. Perform a full push to create a hybrid version with 3 partitions. This push fails because, after the topic switch, real-time consumers cannot find partitions 2 and 3 due to the real-time topic having only 1 partition. Root Cause: - In step 4, if the real-time topic did not exist, it was created with a partition count derived from the largest existing version (batch version with 1 partition), leading to a mismatch. Solution: - STREAM push type is now disallowed if there is no online hybrid version. - If an online hybrid version exists, it ensures the real-time topic partition count matches the hybrid version partition count. - The `requestTopicForPushing` method no longer creates a real-time topic if it does not already exist. This ensures consistency between the real-time topic and hybrid versions, preventing errors during hybrid store operations.
…inc-pushes in child regions when getting version for inc push
|
Moving to draft as I would like to move topic creation in addVersion and see how that works out |
sushantmane
commented
Nov 22, 2024
| @@ -834,6 +834,7 @@ private boolean canSwitchToLeaderTopic(PartitionConsumptionState pcs) { | |||
| private boolean isLocalVersionTopicPartitionFullyConsumed(PartitionConsumptionState pcs) { | |||
| long localVTOff = pcs.getLatestProcessedLocalVersionTopicOffset(); | |||
| long localVTEndOffset = getTopicPartitionEndOffSet(localKafkaServer, versionTopic, pcs.getPartition()); | |||
|
|
|||
There was a problem hiding this comment.
I suspect there is a bug here in this function. I need to think through
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure real-time topic partition count matches hybrid version partition count
This fix addresses an issue where the real-time topic partition count did not align with the hybrid version
partition count, causing errors during hybrid store ingestion. The issue occurred in the following scenario:
switch, real-time consumers cannot find partitions 2 and 3 due to the real-time topic having only 1 partition.
Root Cause:
existing version (batch version with 1 partition), which lead to mismatch.
Solution in this PR:
partition count.
requestTopicForPushingmethod no longer creates a real-time topic if it does not already exist.Misc:
How was this PR tested?
WIP
Does this PR introduce any user-facing changes?