Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[controller] Fix mismatch between hybrid version partition count and real-time partition count #1338

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Commits on Nov 21, 2024

  1. fix: ensure real-time topic partition count matches hybrid version pa…

    …rtition count
    
    This fix addresses an issue where the real-time topic partition count did not align with the hybrid version
    partition count, causing errors during hybrid store operations. The issue occurred in the following scenario:
    
    1. Create a store with 1 partition.
    2. Perform a batch push, creating a batch version with 1 partition.
    3. Update the store to 3 partitions and convert it to a hybrid store.
    4. Start real-time writes using push type STREAM.
    5. Perform a full push to create a hybrid version with 3 partitions. This push fails because, after the topic
       switch, real-time consumers cannot find partitions 2 and 3 due to the real-time topic having only 1 partition.
    
    Root Cause:
    - In step 4, if the real-time topic did not exist, it was created with a partition count derived from the largest
      existing version (batch version with 1 partition), leading to a mismatch.
    
    Solution:
    - STREAM push type is now disallowed if there is no online hybrid version.
    - If an online hybrid version exists, it ensures the real-time topic partition count matches the hybrid version
      partition count.
    - The `requestTopicForPushing` method no longer creates a real-time topic if it does not already exist.
    
    This ensures consistency between the real-time topic and hybrid versions, preventing errors during hybrid store operations.
    sushantmane committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    2386418 View commit details
    Browse the repository at this point in the history
  2. Do not create meta & ps3 RT in parent regions; Skips RT creation for …

    …inc-pushes in child regions when getting version for inc push
    sushantmane committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    4b4113e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    edc8621 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2024

  1. Add isParent checks

    sushantmane committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    7bbe45b View commit details
    Browse the repository at this point in the history
  2. Fix flaky tests

    sushantmane committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    516e78e View commit details
    Browse the repository at this point in the history