Add support for copy directives #35
Conversation
Silvanoc
force-pushed
the
add-support-for-copy-directives
branch
3 times, most recently
from
8f28d95 to
871c49b
Compare
|
No support yet for following
Still working on them, will be included before marking the PR ready. |
Silvanoc
force-pushed
the
add-support-for-copy-directives
branch
2 times, most recently
from
6dcc9c4 to
d69f1ad
Compare
|
@sierra-moxon could you give me some guidance on what should happen if Is it a conflict that should raise an error? Additionally, what is the slot I am not sure if these questions are worth a new issue... |
Silvanoc
force-pushed
the
add-support-for-copy-directives
branch
from
0392afb to
7b54b84
Compare
Silvanoc
force-pushed
the
add-support-for-copy-directives
branch
from
7b54b84 to
294ea91
Compare
|
I would say raise an error |
|
The conflict arose from different versions of pydanticgen, could be resolved manually but probably easiest for you to regen on your branch? |
According 0164002, no error would be needed. It would help usability, but not further than that. Most tools that I know supporting similar filters simply specify priority rules. It is then up to the user to be smart enough on the applied filters and the expected result. |
|
@Silvanoc apologies for the delay. I agree with your proposed interpretation. lmk how you want to proceed with the PR - happy to do this incrementally if we want to merge the current work once the conflict is resolved |
As of now copy_directives can not be specified at TransformationSpecification level to declare that all elements of a schema should be recursively copied. This commit adds this missing support. Signed-off-by: Silvano Cirujano Cuesta <[email protected]>
As of now CopyDirective objects were supported by the specification, but the implementation to handle them was missing. This commit adds support for them. Signed-off-by: Silvano Cirujano Cuesta <[email protected]>
Silvanoc
force-pushed
the
add-support-for-copy-directives
branch
from
294ea91 to
91374bb
Compare
Signed-off-by: Silvano Cirujano Cuesta <[email protected]>
Silvanoc
force-pushed
the
add-support-for-copy-directives
branch
from
91374bb to
8ed00a5
Compare
As of now CopyDirective objects were supported by the specification, but the implementation to handle them was missing.
This PR adds support for them.