You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have read the contributing guideline and understand that I have made the correct modifications
Description:
This is an attempt to deal with the dozens of people who create secrets with errant newlines. By default it will remove any newline characters from secrets before assigning to them envs. There is an undocumented bypass for the 3 people who will inevitably have some horrible edge case where they're legitimately using multi-line envs in secrets.
Actually that's a good point, I hadn't noticed that since I made the changes to standardise this over all the bases during the s6v3 migration that there's a redundant if in there, fixed in 7c6601c
Actually that's a good point, I hadn't noticed that since I made the changes to standardise this over all the bases during the s6v3 migration that there's a redundant if in there, fixed in 7c6601c
I think most of it could be made into a function and then just the top line find command could exec the function. with that find we're also confirming the existence of the files that we're nesting in some if checks currently to reconfirm? (which seems a bit redundant)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
thespad
changed the title
Description:
This is an attempt to deal with the dozens of people who create secrets with errant newlines. By default it will remove any newline characters from secrets before assigning to them envs. There is an undocumented bypass for the 3 people who will inevitably have some horrible edge case where they're legitimately using multi-line envs in secrets.
Benefits of this PR and context:
How Has This Been Tested?
Source / References: