Add VerdictReset variable to ResultData struct to fix verdict metrics never reseting to 0 #120 #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- types.go: Added the VerdictReset to ResultData struct
- collect-data.go: Add condition so chaosresult is skipped when the chaosengine is completed and the verdict was reseted
- handle-result-deletion:
- Add setter for VerdictReset
- Added setter during initialization of resultDetails
- Set the verdictReset value to reset variable in unsetOutdatedMetrics
Signed-off-by: Calvin Audier <[email protected]>
- Adding TSDB_SCRAPE_INTERVAL for the test - Seperating the fetching of the metric in a seperate function - Checking for a verdict on the chaosresult instead of waiting fix amount of time Signed-off-by: Calvin Audier <[email protected]>
Calvinaud
requested review from
ispeakc0de,
ksatchit and
uditgaurav
as code owners
|
Hello, For the testing part of this part I update the BDD case 2 directly since for me it was on the same scope. |
ispeakc0de
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #120Special notes for your reviewer:
Checklist:
documentationtagbreaking-changestagrequires-upgradetag