Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VerdictReset variable to ResultData struct to fix verdict metrics never reseting to 0 #120 #143

Merged
merged 2 commits into from
Aug 24, 2023
Merged

Add VerdictReset variable to ResultData struct to fix verdict metrics never reseting to 0 #120 #143

merged 2 commits into from
Aug 24, 2023

Commits on Aug 1, 2023

  1. Add variable to fix reset of verdict metric litmuschaos#120 

    - types.go: Added the VerdictReset to ResultData struct
- collect-data.go: Add condition so chaosresult is skipped when the chaosengine is completed and the verdict was reseted
- handle-result-deletion:
    - Add setter for VerdictReset
    - Added setter during initialization of resultDetails
    - Set the verdictReset value to reset variable in unsetOutdatedMetrics

Signed-off-by: Calvin Audier <[email protected]>
    @Calvinaud
    Calvinaud committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    d90c734 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2023

  1. Updating test BDD case 2 to include verdict metric 

    - Adding TSDB_SCRAPE_INTERVAL for the test
- Seperating the fetching of the metric in a seperate function
- Checking for a verdict on the chaosresult instead of waiting fix amount of time

Signed-off-by: Calvin Audier <[email protected]>
    Calvin Audier committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    70d29c9 View commit details
    Browse the repository at this point in the history