-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom label for resources in litmus-agent chart #327
Conversation
- Update helpers.tpl for chart and subchart to add custom labels to the labels litmus - Update deployment.yaml/hook-pre-install-job.yaml to add labels to the pods definition - Update values.yaml to include the customs labels on chart and sub chart. Signed-off-by: Calvin Audier <[email protected]>
Update the README.md of the chart and subchart of litmus agent using helm-docs v1.11.0. Signed-off-by: Calvin Audier <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thanks for the contribution. Please, bump the chart version and make sure that CI is green afterwards.
- Bump version of main chart from 0.1.4 to 0.2.0 - Bump version of subchart from 0.1.0 to 0.2.0 Signed-off-by: Calvin Audier <[email protected]>
Hello, I bump the minor version for chart for litmus-agent and for the 5 subcharts. |
Re-update the documentation with helm-docs 1.11.0 after bumping the version Signed-off-by: Calvin Audier <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
What this PR does / why we need it:
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]