Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make some audio config extensions public #569

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bcherry
Copy link
Contributor

@bcherry bcherry commented Jan 29, 2025

This makes it easier to implement a custom configure function by copying the default one, which relies on these non-public extensions to function. Now you can drop in the default and the only thing to change is the log lines.

@bcherry bcherry requested a review from hiroshihorie January 29, 2025 22:10
@hiroshihorie
Copy link
Member

Oh, I think private symbols are being exposed so It's giving errors, I'll check this out later.

@bcherry
Copy link
Contributor Author

bcherry commented Jan 31, 2025

@hiroshihorie weird - just copy-pasting these into my own project is fine without errors 🤷🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants