Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make some audio config extensions public #569

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make some audio config extensions public #569

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80801c2
Make some audio config extensions public
bcherry Jan 29, 2025
421fc31
Merge branch 'main' into bcherry/public-extensions
hiroshihorie Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Sources/LiveKit/Types/AudioSessionConfiguration.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,8 @@
}
}

extension AudioSessionConfiguration {
public extension AudioSessionConfiguration {
func toRTCType() -> LKRTCAudioSessionConfiguration {

Check failure on line 107 in Sources/LiveKit/Types/AudioSessionConfiguration.swift

View workflow job for this annotation

GitHub Actions / test (macos-13, 14.2, macOS,variant=Mac Catalyst) 

cannot use class 'LKRTCAudioSessionConfiguration' here; 'LiveKitWebRTC' has been imported as implementation-only

Check failure on line 107 in Sources/LiveKit/Types/AudioSessionConfiguration.swift

View workflow job for this annotation

GitHub Actions / test (macos-15, 16.2, macOS,variant=Mac Catalyst) 

method must be declared internal because its result uses an internal type

Check failure on line 107 in Sources/LiveKit/Types/AudioSessionConfiguration.swift

View workflow job for this annotation

GitHub Actions / test (macos-15, 16.2, iOS Simulator,OS=18.1,name=iPhone 16 Pro) 

method must be declared internal because its result uses an internal type

Check failure on line 107 in Sources/LiveKit/Types/AudioSessionConfiguration.swift

View workflow job for this annotation

GitHub Actions / test (macos-14, 15.4, iOS Simulator,OS=17.5,name=iPhone 15 Pro) 

method must be declared <<INTERNAL ERROR: encountered %error in diagnostic text>> because its result uses an internal type

Check failure on line 107 in Sources/LiveKit/Types/AudioSessionConfiguration.swift

View workflow job for this annotation

GitHub Actions / test (macos-14, 15.4, macOS,variant=Mac Catalyst) 

method must be declared <<INTERNAL ERROR: encountered %error in diagnostic text>> because its result uses an internal type

Check failure on line 107 in Sources/LiveKit/Types/AudioSessionConfiguration.swift

View workflow job for this annotation

GitHub Actions / test (macos-13, 14.2, iOS Simulator,OS=17.2,name=iPhone 14 Pro) 

cannot use class 'LKRTCAudioSessionConfiguration' here; 'LiveKitWebRTC' has been imported as implementation-only

Check failure on line 107 in Sources/LiveKit/Types/AudioSessionConfiguration.swift

View workflow job for this annotation

GitHub Actions / test (macos-14, 15.4, tvOS Simulator,name=Apple TV) 

method must be declared <<INTERNAL ERROR: encountered %error in diagnostic text>> because its result uses an internal type

Check failure on line 107 in Sources/LiveKit/Types/AudioSessionConfiguration.swift

View workflow job for this annotation

GitHub Actions / test (macos-14, 15.4, visionOS Simulator,name=Apple Vision Pro) 

method must be declared <<INTERNAL ERROR: encountered %error in diagnostic text>> because its result uses an internal type
let configuration = LKRTCAudioSessionConfiguration.webRTC()
configuration.category = category.rawValue
configuration.categoryOptions = categoryOptions
Expand All @@ -113,7 +113,7 @@
}
}

extension LKRTCAudioSession {
public extension LKRTCAudioSession {

Check failure on line 116 in Sources/LiveKit/Types/AudioSessionConfiguration.swift

View workflow job for this annotation

GitHub Actions / test (macos-13, 14.2, macOS,variant=Mac Catalyst) 

cannot use class 'LKRTCAudioSession' in an extension with public or '@usableFromInline' members; 'LiveKitWebRTC' has been imported as implementation-only

Check failure on line 116 in Sources/LiveKit/Types/AudioSessionConfiguration.swift

View workflow job for this annotation

GitHub Actions / test (macos-15, 16.2, macOS,variant=Mac Catalyst) 

cannot use class 'LKRTCAudioSession' in an extension with public or '@usableFromInline' members; 'LiveKitWebRTC' was not imported publicly

Check failure on line 116 in Sources/LiveKit/Types/AudioSessionConfiguration.swift

View workflow job for this annotation

GitHub Actions / test (macos-15, 16.2, iOS Simulator,OS=18.1,name=iPhone 16 Pro) 

cannot use class 'LKRTCAudioSession' in an extension with public or '@usableFromInline' members; 'LiveKitWebRTC' was not imported publicly

Check failure on line 116 in Sources/LiveKit/Types/AudioSessionConfiguration.swift

View workflow job for this annotation

GitHub Actions / test (macos-13, 14.2, iOS Simulator,OS=17.2,name=iPhone 14 Pro) 

cannot use class 'LKRTCAudioSession' in an extension with public or '@usableFromInline' members; 'LiveKitWebRTC' has been imported as implementation-only
func toAudioSessionConfiguration() -> AudioSessionConfiguration {
AudioSessionConfiguration(category: AVAudioSession.Category(rawValue: category),
categoryOptions: categoryOptions,
Expand Down
Loading