Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

25 create a devcontainer for development #26

Merged
merged 27 commits into from
May 29, 2024

Conversation

ll7
Copy link
Owner

@ll7 ll7 commented May 29, 2024

No description provided.

@ll7 ll7 linked an issue May 29, 2024 that may be closed by this pull request
@ll7
Copy link
Owner Author

ll7 commented May 29, 2024

adjust install commands

@ll7
Copy link
Owner Author

ll7 commented May 29, 2024

Should I install the requirements in the dockerfile or in the devcontainer?

ll7 added 14 commits May 29, 2024 09:26
This commit updates the devcontainer.json file to include post-create commands for installing project dependencies and packages. The commands include installing the requirements.txt file, the requirements.txt file in the fast-pysf directory, and the project itself. This ensures that the development environment is properly set up with all the necessary dependencies.
This commit adds the following VS Code extensions to the devcontainer.json file:
- ms-python.python
- ms-vscode-remote.remote-containers
- GitHub.vscode-pull-request-github
- GitHub.copilot
- mhutchie.git-graph
- ms-python.pylint
- genieai.chatgpt-vscode

These extensions enhance the development experience by providing additional functionality and tools within the VS Code editor.
This commit adds the "git submodule update --init --recursive" command to the postCreateCommand section of the devcontainer.json file. This command ensures that the git submodules are properly initialized and updated when creating the development container. This is necessary for the project to function correctly.
This commit updates the devcontainer Dockerfile to use the nvidia/cuda:12.4.1-base-ubuntu22.04 base image instead of the python:3.9 image. This change is made to support GPU acceleration in the development environment.
This commit updates the postCreate.sh script to include commands for installing project dependencies. The script now runs "pip install -r requirements.txt" to install the main project dependencies, "pip install -r fast-pysf/requirements.txt" to install the dependencies for the fast-pysf submodule, and "pip install -e ." and "pip install -e fast-pysf" to install the project itself and the fast-pysf submodule in editable mode. This ensures that the development environment is properly set up with all the necessary dependencies.
… new post create command

This commit adds the "ms-azuretools.vscode-docker" extension to the devcontainer.json file. This extension enhances the development experience by providing Docker-related functionality and tools within the VS Code editor.
…ubuntu20.04

This commit updates the devcontainer Dockerfile to use the nvidia/cuda:11.6.1-base-ubuntu20.04 base image instead of the nvidia/cuda:12.4.1-base-ubuntu22.04 image. This change is made to ensure compatibility with the CUDA version required for GPU acceleration in the development environment.
…ubuntu22.04

Helps with using python>=3.9 = 3.10 for typing issues
@ll7
Copy link
Owner Author

ll7 commented May 29, 2024

Proper testing with gpu integration would be required. but x11 forwarding works under windows.

ll7 added 2 commits May 29, 2024 12:25
…me-ubuntu22.04

use runtime instead of base to have nvidia-smi to check gpu availability
chore: Update devcontainer.json to include "--gpus=all" in runArgs

This commit modifies the devcontainer.json file to include the "--gpus=all" flag in the runArgs section. This flag enables GPU acceleration in the development environment, allowing for the use of GPUs for computational tasks. This change is made to ensure compatibility with the recent updates to the devcontainer Dockerfile that use the nvidia/cuda base image.
This commit adds the "eamodio.gitlens" extension to the devcontainer.json file. GitLens enhances the development experience by providing advanced Git functionality and tools within the VS Code editor.
@ll7 ll7 marked this pull request as ready for review May 29, 2024 12:34
@ll7 ll7 merged commit 6b6c32f into main May 29, 2024
1 check passed
@ll7 ll7 deleted the 25-create-a-devcontainer-for-development branch May 29, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create a devcontainer for development
1 participant