[Support] Recycler: Implement move constructor

[optimisan]

Discovered missing while running RAGreedy through the NPM which relies on moving analyses to the cache.

[optimisan]

• [Support] Recycler: Implement move constructor #120555 : 2 dependent PRs (#117309 , #121889 ) 👈 (View in Graphite)
• [Support] Recycler: Enforce minimum allocation size #121425
• [CodeGen] LiveRegMatrix: Use allocator through a unique_ptr #120556
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[llvmbot]

@llvm/pr-subscribers-llvm-support

Author: Akshat Oke (optimisan)

Changes

...discovered missing while running RAGreedy through the NPM which relies on moving analyses to the cache.

---

Full diff: https://github.com/llvm/llvm-project/pull/120555.diff

1 Files Affected:

• (modified) llvm/include/llvm/Support/Recycler.h (+4)

diff --git a/llvm/include/llvm/Support/Recycler.h b/llvm/include/llvm/Support/Recycler.h
index bbd9ae321ae30c..693c6559ff2fdc 100644
--- a/llvm/include/llvm/Support/Recycler.h
+++ b/llvm/include/llvm/Support/Recycler.h
@@ -60,6 +60,10 @@ class Recycler {
     // clear() before deleting the Recycler.
     assert(!FreeList && "Non-empty recycler deleted!");
   }
+  Recycler(const Recycler &) = delete;
+  Recycler(Recycler &&Other)
+      : FreeList(std::exchange(Other.FreeList, nullptr)) {}
+  Recycler() = default;
 
   /// clear - Release all the tracked allocations to the allocator. The
   /// recycler must be free of any tracked allocations before being

[dwblaikie]

Unit test coverage?

[optimisan]

Merge activity

• Jan 7, 5:16 AM EST: A user started a stack merge that includes this pull request via Graphite.
• Jan 7, 5:17 AM EST: A user merged this pull request with Graphite.

[llvm-ci]

LLVM Buildbot has detected a new failure on builder clang-aarch64-sve-vls running on linaro-g3-02 while building llvm at step 4 "clean stage 1".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/143/builds/4576

Here is the relevant piece of the build log for the reference

Step 4 (clean stage 1) failure: clean (failure)
command timed out: 1200 seconds without output running [b'rm', b'-rf', b'stage1'], attempting to kill
process killed by signal 9
program finished with exit code -1
elapsedTime=1209.003758
Step 6 (build stage 1) failure: 'ninja' (failure)
...
[8313/8797] Building CXX object tools/llvm-jitlink/llvm-jitlink-executor/CMakeFiles/llvm-jitlink-executor.dir/llvm-jitlink-executor.cpp.o
[8314/8797] Building CXX object tools/llvm-link/CMakeFiles/llvm-link.dir/llvm-link.cpp.o
[8315/8797] Building CXX object tools/llvm-mc/CMakeFiles/llvm-mc.dir/llvm-mc.cpp.o
[8316/8797] Building CXX object tools/llvm-dwp/CMakeFiles/llvm-dwp.dir/llvm-dwp-driver.cpp.o
[8317/8797] Linking CXX static library lib/libFIRTestAnalysis.a
[8318/8797] Building CXX object tools/llvm-dwp/CMakeFiles/llvm-dwp.dir/llvm-dwp.cpp.o
[8319/8797] Building CXX object tools/llvm-ifs/CMakeFiles/llvm-ifs.dir/ErrorCollector.cpp.o
[8320/8797] Building CXX object tools/llvm-gsymutil/CMakeFiles/llvm-gsymutil.dir/llvm-gsymutil-driver.cpp.o
[8321/8797] Building CXX object tools/llvm-ifs/CMakeFiles/llvm-ifs.dir/llvm-ifs-driver.cpp.o
[8322/8797] Building CXX object tools/llvm-libtool-darwin/CMakeFiles/llvm-libtool-darwin.dir/llvm-libtool-darwin-driver.cpp.o
command timed out: 1200 seconds without output running [b'ninja'], attempting to kill
process killed by signal 9
program finished with exit code -1
elapsedTime=3591.435876