Add Copilot Arena leaderboard #3618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waynchi
reviewed
Nov 15, 2024
waynchi
reviewed
Nov 15, 2024
waynchi
reviewed
Nov 15, 2024
|
Undraft it! @infwinston |
infwinston
reviewed
Nov 18, 2024
There was a problem hiding this comment.
Thanks overall looks great @adityamittal13 @waynchi ! left one comment
infwinston
reviewed
Dec 18, 2024
fastchat/serve/monitor/monitor.py
Outdated
Comment on lines
1055
to
1058
| with gr.Tab("Copilot Arena Leaderboard", id=5): | ||
| from fastchat.serve.monitor.copilot_arena import build_copilot_arena_tab | ||
|
|
||
| build_copilot_arena_tab() |
There was a problem hiding this comment.
can we make this tab optional and default not showing? Otherwise people who do not have access to COPILOT_ARENA_LEADERBOARD_URL will error out.
We can add an argument to the build_leaderboard_tab function
There was a problem hiding this comment.
What if for simplicity we just try-catch and log it if it doesn't get built?
waynchi
force-pushed
the
aditya-copilot-arena
branch
from
32cc477 to
59b3058
Compare
infwinston
approved these changes
Dec 19, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Adding Copilot Arena leaderboard data to the Chatbot Arena leaderboard as a separate tab. Specifically adding a model ranking leaderboard displaying ELO results.
Related issue number (if applicable)
Checks
format.shto lint the changes in this PR.