Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Skip part of OperatorSpacingSniff because its incorrect behavior #107

Merged
merged 1 commit into from
May 23, 2024

Conversation

OndraM
Copy link
Member

@OndraM OndraM commented May 23, 2024

Out of nowhere (even though PHP_CodeSniffer was probalby not updated in new ECS release - but maybe it was, we don't know) the sniff started to add spaces in every declare statement.

-<?php declare(strict_types=1);
+<?php declare(strict_types = 1);

... which is against PER 2.

@OndraM OndraM changed the base branch from main to 4.0 May 23, 2024 12:45
@OndraM OndraM merged commit 67773cd into 4.0 May 23, 2024
23 checks passed
@OndraM OndraM deleted the fix/declare-spaces-skip branch May 23, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant