Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Skip part of OperatorSpacingSniff because its incorrect behavior #107

Merged
merged 1 commit into from
May 23, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ecs.php
Original file line number Diff line number Diff line change
Expand Up @@ -486,6 +486,11 @@
// We allow empty catch statements (but they must have comment - see EmptyCatchCommentSniff)
EmptyStatementSniff::class . '.DetectedCatch' => null,

// Skip because of its attempts to add spaces in declare(strict_types=1); starting with ECS 12.2.0
// @TODO: In future ECS versions try whether its is still broken or this skip could be removed
OperatorSpacingSniff::class . '.NoSpaceAfter' => null,
OperatorSpacingSniff::class . '.NoSpaceBefore' => null,

// Skip unwanted rules from DocCommentSniff
DocCommentSniff::class . '.ContentAfterOpen' => null,
DocCommentSniff::class . '.ContentBeforeClose' => null,
Expand Down