Skip to content

Commit

Permalink
Test is unnecessary
Browse files Browse the repository at this point in the history
  • Loading branch information
corneliusroemer committed Oct 1, 2024
1 parent 4b84631 commit 21916ab
Showing 1 changed file with 0 additions and 24 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ package org.loculus.backend.controller.submission
import org.hamcrest.CoreMatchers.containsString
import org.hamcrest.CoreMatchers.hasItem
import org.hamcrest.CoreMatchers.`is`
import org.hamcrest.CoreMatchers.notNullValue
import org.hamcrest.MatcherAssert.assertThat
import org.hamcrest.Matchers.allOf
import org.hamcrest.Matchers.containsInAnyOrder
Expand Down Expand Up @@ -99,29 +98,6 @@ class ExtractUnprocessedDataEndpointTest(
.andExpect(header().doesNotExist(ETAG))
}

@Test
fun `GIVEN empty fields in submitted data THEN field is empty string in json response`() {
convenienceClient.submitDefaultFiles()
val response = client.extractUnprocessedData(DefaultFiles.NUMBER_OF_SEQUENCES)
val responseBody = response.expectNdjsonAndGetContent<UnprocessedData>()

assertThat(responseBody, hasSize(greaterThan(0)))

val responseBodyString = response.andReturn().response.contentAsString
val responseBodyStringList = responseBodyString.split("\n").filter(String::isNotEmpty)
val parsedResponseBodyList = responseBodyStringList.map { org.json.JSONObject(it) }

// Verify that no field with path ".data.metadata.*" is null value
// They should be strings, either empty or not
// I.e. fail if any field is null
parsedResponseBodyList.forEach {
val metadata = it.getJSONObject("data").getJSONObject("metadata")
metadata.keys().forEach { key ->
assertThat(metadata.get(key as String), notNullValue())
}
}
}

@Test
fun `WHEN extracting unprocessed data THEN only previously not extracted sequence entries are returned`() {
val submissionResult = convenienceClient.submitDefaultFiles()
Expand Down

0 comments on commit 21916ab

Please sign in to comment.