feat(backend): audit log when someone sets data use terms (#2959)

loculus-project · Oct 7, 2024 · 310e68d · 310e68d
1 parent 60aa2e4
commit 310e68d
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/...d/src/main/kotlin/org/loculus/backend/service/datauseterms/DataUseTermsDatabaseService.kt b/...d/src/main/kotlin/org/loculus/backend/service/datauseterms/DataUseTermsDatabaseService.kt
@@ -10,6 +10,7 @@ import org.loculus.backend.api.DataUseTermsHistoryEntry
 import org.loculus.backend.api.DataUseTermsType
 import org.loculus.backend.auth.AuthenticatedUser
 import org.loculus.backend.controller.NotFoundException
+import org.loculus.backend.log.AuditLogger
 import org.loculus.backend.service.submission.AccessionPreconditionValidator
 import org.loculus.backend.utils.Accession
 import org.springframework.stereotype.Service
@@ -20,6 +21,7 @@ import org.springframework.transaction.annotation.Transactional
 class DataUseTermsDatabaseService(
     private val accessionPreconditionValidator: AccessionPreconditionValidator,
     private val dataUseTermsPreconditionValidator: DataUseTermsPreconditionValidator,
+    private val auditLogger: AuditLogger,
 ) {
 
     fun setNewDataUseTerms(
@@ -47,6 +49,11 @@ class DataUseTermsDatabaseService(
             }
             this[DataUseTermsTable.userNameColumn] = authenticatedUser.username
         }
+
+        auditLogger.log(
+            username = authenticatedUser.username,
+            description = "Set data use terms to $newDataUseTerms for accessions ${accessions.joinToString()}",
+        )
     }
 
     fun getDataUseTermsHistory(accession: Accession): List<DataUseTermsHistoryEntry> {

diff --git a/backend/src/main/kotlin/org/loculus/backend/service/submission/UploadDatabaseService.kt b/backend/src/main/kotlin/org/loculus/backend/service/submission/UploadDatabaseService.kt
@@ -189,6 +189,7 @@ class UploadDatabaseService(
         } ?: emptyList()
 
         if (submissionParams is SubmissionParams.OriginalSubmissionParams) {
+            log.debug { "Setting data use terms for submission $uploadId to ${submissionParams.dataUseTerms}" }
             dataUseTermsDatabaseService.setNewDataUseTerms(
                 submissionParams.authenticatedUser,
                 insertionResult.map { it.accession },
@@ -197,8 +198,8 @@ class UploadDatabaseService(
         }
 
         auditLogger.log(
-            submissionParams.authenticatedUser.username,
-            "Submitted or revised ${insertionResult.size} sequences: " +
+            username = submissionParams.authenticatedUser.username,
+            description = "Submitted or revised ${insertionResult.size} sequences: " +
                 insertionResult.joinToString { it.displayAccessionVersion() },
         )