Skip to content

Commit

Permalink
feat(web): add footer link to docs (Github pages) (#1152)
Browse files Browse the repository at this point in the history 
* feat(web): add footer link to docs (Github pages)

* Fix tests

* Add status back

* f
  • Loading branch information
@corneliusroemer
corneliusroemer authored Feb 26, 2024
1 parent 0ffc245 commit 6279701
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
6 changes: 5 additions & 1 deletion website/src/routes.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,11 @@ export const navigationItems = {
path: routes.aboutPage(),
},
{
text: 'Api documentation',
text: 'Docs',
path: 'https://loculus-project.github.io/loculus/',
},
{
text: 'API docs',
path: routes.apiDocumentationPage(),
},
{
Expand Down
2 changes: 1 addition & 1 deletion website/tests/pages/navigation.spec.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { baseUrl, dummyOrganism, test } from '../e2e.fixture';
const organismIndependentNavigationItems = [
{ link: 'My account', title: 'My account' },
{ link: 'About', title: 'About' },
{ link: 'Api documentation', title: 'Api Docs' },
{ link: 'API docs', title: 'Api Docs' },
{ link: 'Governance', title: 'Governance' },
{ link: 'Status', title: 'Status' },
];
Expand Down

8 comments on commit 6279701

@theosanderson
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this CI cancelled? Does it mean the fix you put in didn't do the trick?

@corneliusroemer
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no clue why it was cancelled - I don't think I did...

Commit comments are tricky, they are very hard to find through notifications/normal search btw

@corneliusroemer
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you cancelled? 🙃
image

@corneliusroemer
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I retried and it worked.

Maybe you didn't manually cancel, but it was some side effect of some action you took?

@theosanderson
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think something may be fairly messed up.. https://github.com/loculus-project/loculus/actions/runs/8056594887/attempts/1
image
fix_ing is my branch, not sure what it's doing here. (Also the "by theosanderson" just indicates that I created the attempt, not that I cancelled it)

@theosanderson
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I accidentally branched fix-ing off your branch. The behaviour seems a bit suboptimal, but hopefully it's a rare case.

@theosanderson
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cause of this is that I branched off main, which is very standard. Branching off main and pushing to the new branch shouldn't cancel main CI.

@corneliusroemer
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix_ing is my branch, not sure what it's doing here. (Also the "by theosanderson" just indicates that I created the attempt, not that I cancelled it)

I'm not sure, it says "by corneliusroemer" for the commits of the same workflow that completed - but "by theo" for the "cancelled" only :)

Just experimented - but wasn't clear before:
image

Please sign in to comment.