fix(website): Add ENA-required NO-PII acknowledgements to our submiss…

…ion acknowledgements (#2333) --------- Co-authored-by: Theo Sanderson <[email protected]> Co-authored-by: Fabian Engelniederhammer <[email protected]> Co-authored-by: Loculus bot <[email protected]>
loculus-project · Jul 30, 2024 · a34eed8 · a34eed8
1 parent 96b6124
commit a34eed8
Show file tree

Hide file tree

Showing 5 changed files with 40 additions and 1 deletion.
diff --git a/website/src/components/Submission/DataUploadForm.tsx b/website/src/components/Submission/DataUploadForm.tsx
@@ -283,6 +283,8 @@ const InnerDataUploadForm = ({
 
     const [agreedToINSDCUploadTerms, setAgreedToINSDCUploadTerms] = useState(false);
 
+    const [confirmedNoPII, setConfirmedNoPII] = useState(false);
+
     const isClient = useClientFlag();
 
     const handleLoadExampleData = async () => {
@@ -305,6 +307,13 @@ const InnerDataUploadForm = ({
             return;
         }
 
+        if (!confirmedNoPII) {
+            onError(
+                'Please confirm the data you submitted does not include restricted or personally identifiable information.',
+            );
+            return;
+        }
+
         if (!metadataFile) {
             onError('Please select metadata file');
             return;
@@ -437,7 +446,23 @@ const InnerDataUploadForm = ({
                                     databases (ENA, DDBJ, NCBI).
                                 </p>
                             )}
-                            <div className='mb-4 mt-3 py-5'>
+                            <div className='mt-2 py-5'>
+                                <label className='flex items-center'>
+                                    <input
+                                        type='checkbox'
+                                        name='confirmation-no-pii'
+                                        className='mr-3 ml-1 h-5 w-5 rounded border-gray-300 text-blue focus:ring-blue'
+                                        checked={confirmedNoPII}
+                                        onChange={() => setConfirmedNoPII(!confirmedNoPII)}
+                                    />
+                                    <div>
+                                        <p className='text-xs pl-4 text-gray-500'>
+                                            I confirm that the data submitted is not sensitive or human-identifiable
+                                        </p>
+                                    </div>
+                                </label>
+                            </div>
+                            <div className='mb-4 py-3'>
                                 <label className='flex items-center'>
                                     <input
                                         type='checkbox'

diff --git a/website/src/components/Submission/SubmissionForm.spec.tsx b/website/src/components/Submission/SubmissionForm.spec.tsx
@@ -72,6 +72,9 @@ describe('SubmitForm', () => {
         await userEvent.click(
             getByLabelText(/I confirm I have not and will not submit this data independently to INSDC/i),
         );
+        await userEvent.click(
+            getByLabelText(/I confirm that the data submitted is not sensitive or human-identifiable/i),
+        );
 
         const submitButton = getByText('Submit sequences');
         await userEvent.click(submitButton);
@@ -141,6 +144,9 @@ describe('SubmitForm', () => {
         await userEvent.click(
             getByLabelText(/I confirm I have not and will not submit this data independently to INSDC/i),
         );
+        await userEvent.click(
+            getByLabelText(/I confirm that the data submitted is not sensitive or human-identifiable/i),
+        );
 
         const submitButton = getByText('Submit sequences');
         await userEvent.click(submitButton);

diff --git a/website/tests/pages/revise/revise.page.ts b/website/tests/pages/revise/revise.page.ts
@@ -16,6 +16,7 @@ export class RevisePage {
         await this.setSequenceFile();
         await this.setRevisedMetadataFile(accessions);
         await this.page.getByText('I confirm I have not and will not submit this data independently to INSDC').click();
+        await this.page.getByText('I confirm that the data submitted is not sensitive or human-identifiable').click();
         await this.page.getByRole('button', { name: 'Submit' }).click();
     }
 

diff --git a/website/tests/pages/submission/index.spec.ts b/website/tests/pages/submission/index.spec.ts
@@ -19,6 +19,7 @@ test.describe('The submit page', () => {
         await Promise.all([submitPage.uploadSequenceData(), submitPage.uploadMetadata()]);
 
         await submitPage.confirmationINSDCTerms.click();
+        await submitPage.confirmationNoPII.click();
         await submitPage.submitButton.click();
 
         await submitPage.page.waitForURL(`${baseUrl}${routes.userSequenceReviewPage(dummyOrganism.key, groupId)}`);
@@ -31,6 +32,7 @@ test.describe('The submit page', () => {
         await Promise.all([submitPage.uploadCompressedSequenceData(), submitPage.uploadCompressedMetadata()]);
 
         await submitPage.confirmationINSDCTerms.click();
+        await submitPage.confirmationNoPII.click();
         await submitPage.submitButton.click();
 
         await submitPage.page.waitForURL(`${baseUrl}${routes.userSequenceReviewPage(dummyOrganism.key, groupId)}`);
@@ -44,6 +46,7 @@ test.describe('The submit page', () => {
         await Promise.all([submitPage.uploadSequenceData(), submitPage.uploadMetadata()]);
         await submitPage.selectRestrictedDataUseTerms();
         await submitPage.confirmationINSDCTerms.click();
+        await submitPage.confirmationNoPII.click();
         await submitPage.submitButton.click();
         await expect(submitPage.page.getByText('Response Sequence Headers')).toBeVisible();
 

diff --git a/website/tests/pages/submission/submit.page.ts b/website/tests/pages/submission/submit.page.ts
@@ -13,6 +13,7 @@ import {
 export class SubmitPage {
     public readonly submitButton: Locator;
     public readonly confirmationINSDCTerms: Locator;
+    public readonly confirmationNoPII: Locator;
     public readonly dataUseTermsDropdown: Locator;
     public readonly loginButton: Locator;
 
@@ -21,6 +22,9 @@ export class SubmitPage {
         this.confirmationINSDCTerms = page.getByText(
             'I confirm I have not and will not submit this data independently to INSDC',
         );
+        this.confirmationNoPII = page.getByText(
+            'I confirm that the data submitted is not sensitive or human-identifiable',
+        );
         this.dataUseTermsDropdown = page.locator('#dataUseTermsDropdown');
         this.loginButton = page.locator('a', { hasText: 'Login or register' });
     }