fixed a todo

loculus-project · Sep 30, 2024 · c9e7d8c · c9e7d8c
1 parent 9ba53e3
commit c9e7d8c
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 5 deletions.
diff --git a/website/src/hooks/useGroupOperations.ts b/website/src/hooks/useGroupOperations.ts
@@ -128,8 +128,17 @@ function callCreateGroup(accessToken: string, zodios: ZodiosInstance<typeof grou
     };
 }
 
+type EditGroupSuccess = {
+    succeeded: true;
+    group: Group;
+};
+type EditGroupError = {
+    succeeded: false;
+    errorMessage: string;
+};
+export type EditGroupResult = EditGroupSuccess | EditGroupError;
+
 function callEditGroup(accessToken: string, zodios: ZodiosInstance<typeof groupManagementApi>) {
-    // TODO
     return async (groupId: number, group: NewGroup) => {
         try {
             const groupResult = await zodios.editGroup(group, {
@@ -141,13 +150,13 @@ function callEditGroup(accessToken: string, zodios: ZodiosInstance<typeof groupM
             return {
                 succeeded: true,
                 group: groupResult,
-            } as CreateGroupSuccess; // TODO change type
+            } as EditGroupSuccess;
         } catch (error) {
             const message = `Failed to create group: ${stringifyMaybeAxiosError(error)}`;
             return {
                 succeeded: false,
                 errorMessage: message,
-            } as CreateGroupError;
+            } as EditGroupError;
         }
     };
 }

diff --git a/website/src/services/groupManagementApi.ts b/website/src/services/groupManagementApi.ts
@@ -21,7 +21,7 @@ const createGroupEndpoint = makeEndpoint({
 const editGroupEndpoint = makeEndpoint({
     method: 'put',
     path: '/groups/:groupId',
-    alias: 'editGroup', // TODO what does this do?
+    alias: 'editGroup',
     parameters: [
         authorizationHeader,
         {
@@ -31,7 +31,7 @@ const editGroupEndpoint = makeEndpoint({
         },
     ],
     response: group,
-    errors: [notAuthorizedError],
+    errors: [notAuthorizedError], // TODO not sure which errors the API can throw
 });
 const addUserToGroupEndpoint = makeEndpoint({
     method: 'put',