hotfix type issue from long searches

[theosanderson]

Fabian made a suggestion to do this with Astro's formData function, which makes perfect sense, but I guess I was misinterpreting what it returned. For now reverting to known working state.

[corneliusroemer]

Woops - how did this get past our CI? Lack of having rebased on main - so some changes between branch-off and current main?

[theosanderson]

I saw a "check website formatting" CI fail, so I reformatted and merged. But actually the check website formatting encompasses type checking too.

[corneliusroemer]

Merge when it passes CI 😝

[corneliusroemer]

But it didn't error in the PR - only when it was rebased onto main, right? Maybe we should always do that as last check before merging - rebase on main and force push to check it applies cleanly.

[theosanderson]

no, this one wasn't about merging. (And IMO making everyone rebase wouldn't be worth the time-cost for this stage of the project)

[corneliusroemer]

You're right, the last tick was just the cache cleanup and not any real checks

Rebase takes like 10 seconds with fork git gui 🙈

[theosanderson]

I don't have fork git GUI :) (and would prefer to have flexibility to work in environments without)