Instead of forcing login, display a message offering users the chance to login #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theosanderson
changed the title
fengelniederhammer
approved these changes
Feb 22, 2024
|
Doesn't this increase the number of clicks required for users to complete common flows? Is this pattern of asking whether to log in more polite? Not sure I have a strong opinion, but I'd generally favour fewer clicks. |
|
It's really hostile for a new user to click "Submit" and find themselves redirected to a page to login to an account they don't even have. Mostly one handles that by not showing users buttons that don't apply to them in their current not logged in state, but here we decided we wanted to always show the button to highlight that you can submit. If so we need a pattern like this. We should keep users logged in for a good length of time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #829
preview URL: https://nice-login.loculus.org/
Summary
Now for the submit and revise pages we use a standardised Astro component to display a page, with a link to Login. In due course we can add Register to this.
Screenshot
PR Checklist