Harden middleware for unenforced login #1091
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -49,6 +49,7 @@ export async function getKeycloakClient() { | |||
| } | |||
|
|
|||
| export const getAuthUrl = async (redirectUrl: string) => { | |||
| redirectUrl = removeTokenCodeFromSearchParams(new URL(redirectUrl)).toString(); | |||
There was a problem hiding this comment.
That redirect URL should also be https, no?
|
I hadn't seen yours until after - if you're happy with how yours is working I'm happy to go with that instead. I haven't tested this much. |
|
Nono, go ahead, we're getting there slowly I think - I'm taking another shot after some sleep in #1097 |
|
Closing in favour of #1098 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1087 maybe
preview URL: https://harden-nice-login.loculus.org/
Summary
Clears session cookie when there is an error getting user info, even if not on an enforced login page, and ensures we don't redirect to a page with session parameters in the redirect Uri