Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website): use static classnames required by tailwindcss #1107

Merged
merged 2 commits into from
Feb 25, 2024

Conversation

corneliusroemer
Copy link
Contributor

@corneliusroemer corneliusroemer commented Feb 25, 2024

preview URL: https://fix-indentation.loculus.org

Summary

Using typescript to ensure the static class mapping is exhaustive
and remains so in the future

See: https://loculus.slack.com/archives/C05G172HL6L/p1708816924708099

Screenshot

Before (wrong indentation of mpox etc)
image

After (right indentation):
image

Using typescript to ensure the static class mapping is exhaustive
and remains so in the future
@corneliusroemer
Copy link
Contributor Author

Went through whole codebase and this was the only bug of this kind, except for #1108

Copy link
Member

@chaoran-chen chaoran-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

@corneliusroemer corneliusroemer merged commit 16eb61e into main Feb 25, 2024
12 checks passed
@corneliusroemer corneliusroemer deleted the fix-indentation branch February 25, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Triggers a deployment to argocd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants