Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test): Rename nav link text from Search -> Browse #1117

Merged
merged 1 commit into from
Feb 25, 2024
Merged

fix(test): Rename nav link text from Search -> Browse #1117

merged 1 commit into from
Feb 25, 2024

Conversation

corneliusroemer
Copy link
Contributor

No description provided.

@corneliusroemer
Copy link
Contributor Author

@theosanderson you broke it 😛

@theosanderson
Copy link
Member

I don't remember merging anything that broke it..

@corneliusroemer
Copy link
Contributor Author

corneliusroemer commented Feb 25, 2024 •
edited
Loading

I think here: 3cb7cde#diff-8dd0d2fda7ed83830896ebe5ffb72366b8083633857b522aaede5f639be3dd1bL193-R202

But don't worry - these tests are maybe a little too specific for this stage of development, I guess
https://github.com/loculus-project/loculus/actions/runs/8040770550/job/21959257853

@corneliusroemer corneliusroemer merged commit d34fb80 into main Feb 25, 2024
12 checks passed
@corneliusroemer corneliusroemer deleted the fix-e2e branch February 25, 2024 23:56
@theosanderson
Copy link
Member

Yes. You merged that PR while it had a failed test. In general our policy is to leave people to merge their own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theosanderson theosanderson theosanderson approved these changes

@chaoran-chen chaoran-chen Awaiting requested review from chaoran-chen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@corneliusroemer @theosanderson