Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website): Handle 503 error from SILO #1132

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Conversation

fengelniederhammer
Copy link
Contributor

@fengelniederhammer fengelniederhammer commented Feb 26, 2024

preview URL: https://lapis503error.loculus.org/

Summary

See GenSpectrum/LAPIS-SILO#295. SILO throws an error now when it did not load a database yet.

PR Checklist

  • [ ] All necessary documentation has been adapted.
  • [ ] The implemented feature is covered by an appropriate test.

@fengelniederhammer fengelniederhammer added website Tasks related to the web application preview Triggers a deployment to argocd labels Feb 26, 2024
@fengelniederhammer fengelniederhammer added this to the MVP (closed beta) milestone Feb 26, 2024
Copy link
Member

@theosanderson theosanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm apart from linting

@theosanderson
Copy link
Member

I guess we need to increase maxNumberOfRetries or add some back off time

Copy link
Contributor

@TobiasKampmann TobiasKampmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@corneliusroemer corneliusroemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Errors are handled but E2E still fails - but I guess this is expected?

https://github.com/loculus-project/loculus/actions/runs/8050298126/job/21988680241?pr=1132#step:19:52

@fengelniederhammer
Copy link
Contributor Author

I don't know why this happens. Locally it works...

See GenSpectrum/LAPIS-SILO#295
SILO throws an error now when it did not load a database yet.
@corneliusroemer
Copy link
Contributor

corneliusroemer commented Feb 26, 2024

IIUC, Silo is up per the "pods ready step" - strange
https://github.com/loculus-project/loculus/actions/runs/8050298126/job/21988680241?pr=1132#step:17:112

Seems to be running but somehow not initialized

@theosanderson
Copy link
Member

Seems to be OK now :)

@fengelniederhammer fengelniederhammer merged commit bd2848c into main Feb 26, 2024
12 checks passed
@fengelniederhammer fengelniederhammer deleted the lapis503Error branch February 26, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Triggers a deployment to argocd website Tasks related to the web application
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants