Add waits for all docker images to update argocd_metadata #1202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should wait - we shouldn't be pointing to images which might have failed to be built. (Feel free to add more waits!) |
|
Otherwise we end up in a state where if we delete the main app it will never restart |
|
Your race condition point is a good reason to use |
corneliusroemer
changed the title
Reintroduce waits
As @theosanderson said: Your race condition point is a good reason to use concurrency, but without cancel-in-progress
corneliusroemer
force-pushed
the
dont-wait-argocd
branch
from
ea75805
to
446fffc
Compare
|
CI checks here are unnecessary, as it doesn't test this workflow. |
theosanderson
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should wait for all images (including nextclade, dummy, keycloakify, config processor) and not just website and backend.
@theosanderson if we need them all let me know and I'll update. But the current situation is likely not the best.