Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(website): filter by data use terms in download panel #1218

Merged
merged 2 commits into from
Mar 3, 2024

Conversation

chaoran-chen
Copy link
Member

@chaoran-chen chaoran-chen commented Mar 3, 2024

resolves #852

preview URL: https://852-download-panel-data-u.loculus.org/

Summary

The data use term filter (i.e., "include restricted data"?) didn't work before and always included all data. This is now fixed.

Screenshot

As you can see, by default, only open data are included:

image

PR Checklist

  • [ ] All necessary documentation has been adapted.
  • The implemented feature is covered by an appropriate test.

@chaoran-chen chaoran-chen added the preview Triggers a deployment to argocd label Mar 3, 2024
@chaoran-chen chaoran-chen self-assigned this Mar 3, 2024
@chaoran-chen chaoran-chen linked an issue Mar 3, 2024 that may be closed by this pull request
Copy link
Member

@theosanderson theosanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Base automatically changed from 1216-fix-download-panel to main March 3, 2024 20:19
@chaoran-chen chaoran-chen merged commit 7fbbc92 into main Mar 3, 2024
12 checks passed
@chaoran-chen chaoran-chen deleted the 852-download-panel-data-use-terms-filter branch March 3, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Triggers a deployment to argocd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Download panel: data use term filter
2 participants