Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some suggestions for the Search help feature #2234

Merged
merged 6 commits into from
Jul 4, 2024
Merged

Some suggestions for the Search help feature #2234

merged 6 commits into from
Jul 4, 2024

Conversation

theosanderson
Copy link
Member

@theosanderson theosanderson commented Jul 2, 2024 •
edited
Loading

Some suggestions for the Search help implementation
https://search2.loculus.org/ebola-sudan/search

image
  • Use HeadlessUI to implement the modal (the original has 2 "X" buttons for example, which this avoids)
  • Restyle buttons at the top
  • Restyle help button on mutations field

@theosanderson theosanderson added the preview Triggers a deployment to argocd label Jul 2, 2024
@theosanderson theosanderson mentioned this pull request Jul 2, 2024
Merged
anna-parker
anna-parker approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@anna-parker anna-parker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test should be a quick fix as the button label has only just changed from Customize to Select - I think this looks awesome!

@theosanderson theosanderson added the format_me Triggers github_actions to format website code on PR label Jul 4, 2024
@theosanderson theosanderson merged commit 5fc5758 into search Jul 4, 2024
@theosanderson theosanderson deleted the search2 branch July 4, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anna-parker anna-parker anna-parker approved these changes

Assignees
No one assigned
Labels
format_me Triggers github_actions to format website code on PR preview Triggers a deployment to argocd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theosanderson @anna-parker