Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

give group and submitter information to the preprocessing pipeline #2268

Merged
merged 1 commit into from
Jul 9, 2024
Merged

give group and submitter information to the preprocessing pipeline #2268

merged 1 commit into from
Jul 9, 2024

Conversation

fengelniederhammer
Copy link
Contributor

@fengelniederhammer fengelniederhammer commented Jul 8, 2024 •
edited
Loading

resolves #2263

preview URL: https://2263-give-group-and-submi.loculus.org/

Summary

Added 4 fields to the data that is sent to the preprocessing pipeline (/extract-unprocessed-data):

  • submissionId (String)
  • submitter (String)
  • groupId (Int)
  • submittedAt (Long, as timestamp)

Other fields, such as approver and released_at are not set yet.

Screenshot

PR Checklist

  • All necessary documentation has been adapted.
  • The implemented feature is covered by an appropriate test.

@fengelniederhammer fengelniederhammer added the preview Triggers a deployment to argocd label Jul 8, 2024
@fengelniederhammer fengelniederhammer mentioned this pull request Jul 8, 2024
Merged
2 tasks
@fengelniederhammer fengelniederhammer force-pushed the 2263-give-group-and-submitter-information-to-the-preprocessing-pipeline branch 2 times, most recently from 0501211 to 6d921d5 Compare July 8, 2024 15:49
@fengelniederhammer
feat: add Loculus internal metadata to data that is sent to preproces…
4a1b45c 
…sing pipeline #2263

There are more Loculus internal metadata fields, but they are not filled with data at this point of the submission process
@fengelniederhammer fengelniederhammer force-pushed the 2263-give-group-and-submitter-information-to-the-preprocessing-pipeline branch from 6d921d5 to c381638 Compare July 8, 2024 16:01
chaoran-chen
chaoran-chen reviewed Jul 8, 2024
View reviewed changes
Copy link
Member

@chaoran-chen chaoran-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

backend/src/main/resources/db/migration/V1__init.sql Outdated Show resolved Hide resolved
backend/src/main/resources/db/migration/V1__init.sql Outdated Show resolved Hide resolved
@fengelniederhammer fengelniederhammer force-pushed the 2263-give-group-and-submitter-information-to-the-preprocessing-pipeline branch from c381638 to 4a1b45c Compare July 9, 2024 06:28
chaoran-chen
chaoran-chen approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@chaoran-chen chaoran-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me - thanks!

@fengelniederhammer fengelniederhammer merged commit b74e37e into main Jul 9, 2024
@fengelniederhammer fengelniederhammer deleted the 2263-give-group-and-submitter-information-to-the-preprocessing-pipeline branch July 9, 2024 13:23
@anna-parker anna-parker mentioned this pull request Jul 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaoran-chen chaoran-chen chaoran-chen approved these changes

Assignees
No one assigned
Labels
preview Triggers a deployment to argocd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Give group and submitter information to the preprocessing pipeline
2 participants
@fengelniederhammer @chaoran-chen