refactor(website): refactor search by extracting re-usable functions #2288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theosanderson
changed the title
theosanderson
changed the title
theosanderson
requested review from
anna-parker,
corneliusroemer and
chaoran-chen
chaoran-chen
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(did this stuff on a plane where I was limited on what tasks I could work on due to lack of internet)
This PR refactors search to extract a lot of re-usable functions. This improves the code in itself by providing smaller named modular functions. It also puts a lot of foundations in place to allow us to fetch search results server side as well as client side to restore SSR.
Note to reviewers: these changes are almost entirely simply moving code rather than fundamentally rewriting it. This is partly to help with visibility of actual changes, in a subsequent PR.
Preview: https://refactor-search.loculus.org/