-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ena-submission): Create ena projects #2293
Conversation
d88d723
to
6eaac3b
Compare
8814be7
to
ab8ec79
Compare
25a68f0
to
97d1244
Compare
65ce5d2
to
a11d5b0
Compare
…eep state in database.
2cfe26e
to
c150cc0
Compare
c150cc0
to
1c676da
Compare
@@ -6,7 +6,7 @@ disableWebsite: false | |||
disableBackend: false | |||
disablePreprocessing: false | |||
disableIngest: false | |||
disableEnaSubmission: true | |||
disableEnaSubmission: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For final PR it would be nice to do this in the values_preview_server.yaml
rather than in the default Helm chart - until ENA submission is fully mature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(and actually even after that, because many Loculus instances wouldn't use this)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added in #2831
Drive-by edits in this PR - might be good to merge these frequently to prevent merge conflicts from getting out of hand with the many branches open: #2663 |
Closing as this was part of #2417 |
resolves #2399
preview URL: https://create-ena-projects.loculus.org/
Summary
This adds the following rule to the ena-submission snakemake file :
project_creation
rule . This function will continuously (in a loop) scan for new sequences where a project needs to be created and trigger their creation. It will also update both thesubmission_table
and theproject_table
.High level overview of
project_creation
:In a loop:
submission_table
in state READY_TO_SUBMITproject_table
for the corresponding (group_id, organism)):-- if (entry is in status SUBMITTED): update
submission_table
to SUBMITTED_PROJECT.-- else: update
submission_table
to SUBMITTING_PROJECT.project_table
for (group_id, organism).submission_table
in state SUBMITTING_PROJECTproject_table
entry is in state SUBMITTED): update entries to state SUBMITTED_PROJECT.project_table
in state READY, prepare submission object, set status to SUBMITTINGproject_table
in state HAS_ERRORS for over 15min and sequences in status SUBMITTING for over 15min: #TODO (handle failure ena-submission: Recover from failed project/sample/assembly submission #2311), currently just throw an errorENA Project
This PR will create projects in ENA with the following attributes:
Screenshot
PR Checklist
Confirmed locally this will resend messages to our slack channel every 15minutes