Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deployment): Add basic resource requirements for config processor and other initContainers #2340

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

theosanderson
Copy link
Member

@theosanderson theosanderson commented Jul 25, 2024

We had no resource requirements specified for the config preprocessor, and for some other initContainers. Now with server side apply set this is leading everything to appear out of sync like this:

image

This should fix that

@theosanderson theosanderson changed the title Add basic resource requirements for config processor fix(deployment): Add basic resource requirements for config processor Jul 25, 2024
@theosanderson theosanderson added the preview Triggers a deployment to argocd label Jul 25, 2024
@theosanderson theosanderson changed the title fix(deployment): Add basic resource requirements for config processor fix(deployment): Add basic resource requirements for config processor and other initContainers Jul 25, 2024
@theosanderson theosanderson enabled auto-merge (squash) July 25, 2024 15:50
@theosanderson
Copy link
Member Author

Once this is approved merge it into your preview branches - until then they will be constantly trying to resync themselves

@theosanderson theosanderson merged commit b6e3b19 into main Jul 25, 2024
10 checks passed
@theosanderson theosanderson deleted the resource-reqs branch July 25, 2024 15:51
anna-parker pushed a commit that referenced this pull request Jul 29, 2024
… and other initContainers (#2340)

* add basic resource requirements for config processor

* specify more resources
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Triggers a deployment to argocd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants