Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(depoyment): Update appset.yaml to reflect latest live version #2341

Merged

Conversation

theosanderson
Copy link
Member

@theosanderson theosanderson commented Jul 25, 2024

  • Removed unused namespace field
  • Added server side apply to prevent severe limits on our config map sizes.
  • Added bannerMessage which was present on live but had not been captured here

This was generated by patching a file acquired with kubectl get appset -o yaml so formatting is not preserved

@theosanderson theosanderson changed the title Update appset.yaml to reflect latest live version chore(depoyment): Update appset.yaml to reflect latest live version Jul 25, 2024
@theosanderson theosanderson added the review please PR waiting for final review label Jul 25, 2024
- Removed unused `namespace` field
- Added server side apply

This was generated by patching a file acquired with `kubectl get appset -o yaml` so formatting is not preserved
@corneliusroemer corneliusroemer force-pushed the Update-appset.yaml-to-reflect-latest-live-version branch from 5de44bc to 213402f Compare July 25, 2024 16:10
@theosanderson theosanderson merged commit f9e6075 into main Jul 25, 2024
10 checks passed
@theosanderson theosanderson deleted the Update-appset.yaml-to-reflect-latest-live-version branch July 25, 2024 16:39
anna-parker pushed a commit that referenced this pull request Jul 29, 2024
- Removed unused `namespace` field
- Added server side apply

This was generated by patching a file acquired with `kubectl get appset -o yaml` so formatting is not preserved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review please PR waiting for final review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants