Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cornelius' edits of the header count PR #2774

Closed
wants to merge 1 commit into from
Closed

Cornelius' edits of the header count PR #2774

wants to merge 1 commit into from

Conversation

corneliusroemer
Copy link
Contributor

resolves #

preview URL:

Summary

Screenshot

PR Checklist

  • All necessary documentation has been adapted.
  • The implemented feature is covered by an appropriate test.

@corneliusroemer corneliusroemer added the preview Triggers a deployment to argocd label Sep 12, 2024
anna-parker
anna-parker approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@anna-parker anna-parker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Feel free to merge - let me know if you find a way to calculate the count and stream on the same database state

@anna-parker
Copy link
Contributor

I cherry picked your changes onto my PR - is it ok to close this?

@corneliusroemer
Copy link
Contributor Author

For sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anna-parker anna-parker anna-parker approved these changes

Assignees
No one assigned
Labels
preview Triggers a deployment to argocd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@corneliusroemer @anna-parker