Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add countries in NIH list which are missing from ENA list #2813

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

anna-parker
Copy link
Contributor

@anna-parker anna-parker commented Sep 17, 2024

resolves #2636

preview URL: https://add-nih-countries.loculus.org/

Summary

As calculated in #2335 these are the countries on the NIH list yet missing from the ENA list, adding them here for consistency.

For reference here is:

I added these countries to the end of the list. Currently we do not use the ENA checklist for verification - if this changes these countries will need to be properly mapped.

Screenshot

PR Checklist

@anna-parker anna-parker added the preview Triggers a deployment to argocd label Sep 17, 2024
@anna-parker anna-parker marked this pull request as ready for review September 17, 2024 11:10
@anna-parker
Copy link
Contributor Author

We should probably also add the historical names in case someone submits older data:

Belgian Congo
British Guiana
Burma
Czechoslovakia
Czech Republic
East Timor
Korea
Macedonia
Micronesia
Netherlands Antilles
Serbia and Montenegro
Siam
Swaziland
The former Yugoslav Republic of Macedonia
USSR
Yugoslavia
Zaire

@corneliusroemer
Copy link
Contributor

How is Czech Republic a historic name? 👀

@corneliusroemer
Copy link
Contributor

They now call it Czechia. I see. It would be great if there was a cutoff date for each historical name. One shouldn't use Soviet Union past 1990 etc. We could come up with our own cut offs. Czechia/Czech Republic is weird though.

What about Turkey/Türkiye? It still says Turkey but I bet Turkey would prefer Türkiye.

@anna-parker
Copy link
Contributor Author

Did a more thorough investigation and the only fields only in ENA and not in NIH are:

'East Timor',
 'Macedonia',
 'Micronesia',
 'Swaziland'

which are in NIH's historical list. Here we add the NIH list and NIH's list of historical countries.

@anna-parker anna-parker merged commit 048f7d9 into main Sep 18, 2024
15 checks passed
@anna-parker anna-parker deleted the add_nih_countries branch September 18, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Triggers a deployment to argocd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

South Sudan missing in accepted countries due to missing from ENA checklist
2 participants