-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add countries in NIH list which are missing from ENA list #2813
Conversation
949c16e
to
eb51171
Compare
We should probably also add the historical names in case someone submits older data:
|
How is Czech Republic a historic name? 👀 |
They now call it Czechia. I see. It would be great if there was a cutoff date for each historical name. One shouldn't use Soviet Union past 1990 etc. We could come up with our own cut offs. Czechia/Czech Republic is weird though. What about Turkey/Türkiye? It still says Turkey but I bet Turkey would prefer Türkiye. |
Did a more thorough investigation and the only fields only in ENA and not in NIH are:
which are in NIH's historical list. Here we add the NIH list and NIH's list of historical countries. |
…istorical countries as addendum below alphabetized list.
b39f4b0
to
9970526
Compare
resolves #2636
preview URL: https://add-nih-countries.loculus.org/
Summary
As calculated in #2335 these are the countries on the NIH list yet missing from the ENA list, adding them here for consistency.
For reference here is:
I added these countries to the end of the list. Currently we do not use the ENA checklist for verification - if this changes these countries will need to be properly mapped.
Screenshot
PR Checklist